Conversation
Collaborator
|
Staged preview of the updated flutter.dev site (updated for commit 31334e9): https://flutter-dev-230821--www-pr13796-cli-bc-bza14d47.web.app |
10 tasks
camsim99
marked this pull request as ready for review
August 27, 2026 00:01
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new documentation page explaining a breaking change that restricts command-line flags on prebuilt Android release binaries. Feedback on the documentation suggests correcting the highlighted line range in the XML code block to exclude the unrelated <activity> tag, and removing or replacing a Google-internal shortlink with a public reference.
Collaborator
|
Staged preview of the updated docs.flutter.dev site (updated for commit 31334e9): https://flutter-docs-prod--docs-pr13796-cli-bc-9xazfynb.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
Adds breaking change docs for restricting setting engine configuration flags on the command line when running a Flutter Android app in release mode with a prebuilt binary, i.e.
flutter run --release --use-application-binary.Issues fixed by this PR (if any):
Part of flutter/flutter#190461
PRs or commits this PR depends on (if any):
flutter/flutter#190870
Presubmit checklist
of 80 characters or fewer.